Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out unused dependencies in Go #119

Merged
merged 4 commits into from
Aug 31, 2021
Merged

Filter out unused dependencies in Go #119

merged 4 commits into from
Aug 31, 2021

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Aug 27, 2021

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

Resolves #109

Filter out unused dependencies in Go by intersecting go mod graph results with go list -m all results.
The results of go list -m all should show only dependencies that are actually in use in the project.
Read more about this issue here: #109 (comment)

@yahavi yahavi requested a review from eyalbe4 August 27, 2021 10:11
@yahavi yahavi self-assigned this Aug 27, 2021
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yahavi - as for the usage of go list -m all, will you be able to sync with @sverdlov93?
Michael may have found a way of making the result of go list -m all more precise, by setting the output format.

Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the Go Projects section in the README following these changes.

@yahavi yahavi merged commit 590cd88 into jfrog:master Aug 31, 2021
@yahavi yahavi deleted the go-filter branch August 31, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension host terminated unexpectedly for Golang project
2 participants