Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the "fix action" for indirect dependencies #500

Merged

Conversation

eyalk007
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

The fix dependency option is being offered on indirect dependencies. Obviously this is an impossible task for us, so i blocked the ability by adding the check to the existing if statement.

@eyalk007 eyalk007 self-assigned this Oct 31, 2024
@eyalk007 eyalk007 added the bug Something isn't working label Oct 31, 2024
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Oct 31, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 31, 2024
@eyalk007
Copy link
Contributor Author

eyalk007 commented Oct 31, 2024

image03917eb47bc9">

after

@eyalk007
Copy link
Contributor Author

image

before

@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Nov 3, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 3, 2024
@eyalk007 eyalk007 force-pushed the bug-fix/cancel-fix-for-indirect-deps branch from 0f049b7 to a0fa773 Compare November 3, 2024 11:34
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Nov 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.


@eyalk007 eyalk007 merged commit 1ae8680 into jfrog:master Nov 4, 2024
7 checks passed
@eyalk007 eyalk007 deleted the bug-fix/cancel-fix-for-indirect-deps branch November 4, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants