Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct default in external dependencies patterns description #267

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Correct default in external dependencies patterns description #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/resources/artifactory_remote_helm_repository.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,6 @@ All generic repo arguments are supported, in addition to:
* `helm_charts_base_url` - (Optional) - No documentation is available. Hopefully you know what this means
* `external_dependencies_enabled` - (Optional) When set, external dependencies are rewritten.
* `external_dependencies_patterns` - (Optional) An Allow List of Ant-style path expressions that specify where external
dependencies may be downloaded from. By default, this is set to ** which means that dependencies may be downloaded
from any external source.
dependencies may be downloaded from. By default, this is an empty list which means that no dependencies may be downloaded
from external sources. Note that the official documentation states the default is '**', which is correct when creating
repositories in the UI, but incorrect for the API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW!!!!!! I mean, I am shocked but not suprised.

4 changes: 3 additions & 1 deletion pkg/artifactory/resource_artifactory_remote_helm_repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ var helmRemoteSchema = mergeSchema(baseRemoteSchema, map[string]*schema.Schema{
},
RequiredWith: []string{"external_dependencies_enabled"},
Description: "An Allow List of Ant-style path expressions that specify where external dependencies may be downloaded from. " +
"By default, this is set to ** which means that dependencies may be downloaded from any external source.",
"By default, this is an empty list which means that no dependencies may be downloaded from external sources. " +
"Note that the official documentation states the default is '**', " +
"which is correct when creating repositories in the UI, but incorrect for the API.",
},
})

Expand Down