-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop extending into ERB the t
and textilize
#19
Open
dmitry
wants to merge
9
commits into
jgarber:master
Choose a base branch
from
dmitry:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jun 16, 2017
-
Stop extending into ERB the
t
andtextilize
Prevent injection of the `t` and `textilize` methods into a `ERB` module through the `Util` module. When using the `i18n` gem in Rails it uses textilize method, instead of `translate` (aliased as `t`) helper. It will be still possible to inject textilize into a ERB after this commit with a manual code: ``` begin require 'erb' require 'redcloth/erb_extension' include ERB::Util rescue LoadError end ```
Configuration menu - View commit details
-
Copy full SHA for 85b3dc8 - Browse repository at this point
Copy the full SHA 85b3dc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50049da - Browse repository at this point
Copy the full SHA 50049daView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdd02b0 - Browse repository at this point
Copy the full SHA cdd02b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a12a118 - Browse repository at this point
Copy the full SHA a12a118View commit details -
Configuration menu - View commit details
-
Copy full SHA for f58e1a1 - Browse repository at this point
Copy the full SHA f58e1a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a25fa78 - Browse repository at this point
Copy the full SHA a25fa78View commit details -
Configuration menu - View commit details
-
Copy full SHA for a262b5b - Browse repository at this point
Copy the full SHA a262b5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c47155 - Browse repository at this point
Copy the full SHA 7c47155View commit details
Commits on Jun 20, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 0b4bcc6 - Browse repository at this point
Copy the full SHA 0b4bcc6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.