Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop checking for main function in libc #74

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

casperisfine
Copy link

It makes very little sense and the commit that introduced this never explained why it's doing it.

This cause compilation for fail is ruby was installed with the --disable-install-static-library flag.

It makes very little sense and the commit that introduced this
never explained why it's doing it.

This cause compilation for fail is ruby was installed with the
--disable-install-static-library flag.
@heliocola
Copy link
Collaborator

@casperisfine : thanks for spotting this and submitting this PR.
I've looked into the definition of the have_function (and checking_message, and checking_for) and it just returns true or false, so whether it is true or false, the compilation will continue on.

I also run compile/build/test on my machine (which i used to release the last version) and all seems good.

Given this was created a while ago, I am still situating myself, I wanted to check-in if you'd expect this cause other problems.

@casperisfine
Copy link
Author

wanted to check-in if you'd expect this cause other problems.

I don't.

@heliocola heliocola merged commit e024f38 into jgarber:master Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants