Fix whitespace in negative charclasses #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In vim patterns, `\s` inside a "collection" matches literal s, not
space-or-tab. Buried in `:help collection` is this factoid:
NOTE: The other backslash codes mentioned above do not work inside
[]!
So before this fix, `_something_` wouldn't start an emphasis at the first
underscore because the pattern for the syntax region required underscore
not-followed-by `s`. This diff replaces `\s` inside square bracket
patterns with `[:blank:]`, which is a character class expression for
"space or tab".
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In vim patterns,
\sinside a "collection" matches literal s, not space-or-tab. Buried in:help collectionis this factoid:So before this fix,
_something_wouldn't start an emphasis at the first underscore because the pattern for the syntax region required underscore not-followed-bys. This diff replaces\sinside square bracket patterns with[:blank:], which is a character class expression for "space or tab".