Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Null constructor from Block. #108

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Remove Null constructor from Block. #108

merged 1 commit into from
Jan 13, 2023

Conversation

tarleb
Copy link
Contributor

@tarleb tarleb commented Jan 13, 2023

[API change]

Closes #91.

@tarleb
Copy link
Contributor Author

tarleb commented Jan 13, 2023

This just reintroduces the commit that had been reverted.

@jgm
Copy link
Owner

jgm commented Jan 13, 2023

If we did this, would we want to filter out null elements from JSON arrays? (See discussion in #91) That would mean not using the automatically generated instances for [Block].

@tarleb
Copy link
Contributor Author

tarleb commented Jan 13, 2023

I think that might best be left to the filter library.

@jgm jgm merged commit 8c7bc6c into jgm:master Jan 13, 2023
@tarleb tarleb deleted the remove-null branch January 13, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Null?
2 participants