-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[revealjs] Setting slide-level does not change the way header in divs are considered as new slides #8098
Comments
I think it might make sense to create a new function It seems that the HTML writer always creates sections, but doesn't always keep them around in the final output. I wonder why we are doing it this way? |
See also #8097, another manifestation of the complexity we currently have. We could probably special-case this by telling the HTML writer that a Div with class "fragment" should not create a section. Ultimately, though, it would be nice to have a cleaner design. One natural idea (proposed in #5965) is to add the section divs in T.P.App, prior to calling the writers. But the current design of the HTML writer assumes that we've got the section information in the AST, regardless of |
We already special-case for 'column' and 'columns', so I'll just add 'fragment'. |
revert #1053 (cd72d7c) while keeping the test now that it is fixed upstream (jgm/pandoc#8098)
This issue is a follow up on #6705 after I stumble upon what I think is an undesired for reveal JS slides.
Take this example
This will correctly give us 1 title slide, then 2 vertical slide, first of which contains a
<h3>
headerNow let's add a Fenced div around the h3 part
We now get the
<h3>
, embed in a new<section>
and not just a<div>
From change in pandoc 2.8 and discussion in #6705, I was under the impression that a section slide should be created for header in divs with level below the slide level.
Why this is a problem ?
<section>
in revealjs means a new slide. If you generated a presentation using the above content, the slide navigation will be messed up especially if you activated some other revealjs feature that are based sections likehistory: true
Try above content with fenced div using this command
If you open presentation an navigate using keyboard, you won't be able to reach the last slide, it will look withing the first ones.
The overview of presentation slides will show an unexpected empty slide
where there is none when not using a fenced div
The trick from @tarleb is still working
but I was under the impression from #6705 it should have behave differently if
--slide-level=2
was set, and h3 used within Div. I tested with version 2.8 though, and it was already working this way creating sections.Opening this for discussion, if anyone else agree that this should work differently for revealjs presentation than usual HTML.
The text was updated successfully, but these errors were encountered: