Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for \faCheck and \faClose #3727

Merged
merged 1 commit into from
Jun 11, 2017
Merged

Support for \faCheck and \faClose #3727

merged 1 commit into from
Jun 11, 2017

Conversation

schrieveslaach
Copy link
Contributor

This PR adds support for some fontawesome commands.

Check: ✓
Close: ✗

@jgm
Copy link
Owner

jgm commented Jun 9, 2017

What LaTeX package enables these?

@schrieveslaach
Copy link
Contributor Author

Sorry, I forget to include the package name. It is fontawesome.

@jgm jgm merged commit f36de77 into jgm:master Jun 11, 2017
@jgm
Copy link
Owner

jgm commented Jun 11, 2017

Looks good. I'm not sure whether we should be supporting semi-obscure packages like this, but in this case at least there seems little risk of a conflict with the names.

@schrieveslaach schrieveslaach deleted the fontawesome branch June 12, 2017 06:45
@schrieveslaach
Copy link
Contributor Author

schrieveslaach commented Jun 12, 2017

Thanks for merging.

What do mean by “semi-obscure”?

@jgm
Copy link
Owner

jgm commented Jun 12, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants