flatten nested inlines following readability criteria, closes #4368 #4554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgm
reviewed
Apr 16, 2018
test/writer.rst
Outdated
| @@ -649,8 +649,8 @@ Smart quotes, ellipses, dashes | |||
|
|
|||
| ‘He said, “I want to go.”’ Were you alive in the 70’s? | |||
|
|
|||
| Here is some quoted ‘``code``’ and a “`quoted | |||
| link <http://example.com/?foo=1&bar=2>`__”. | |||
| Here is some quoted ‘``code``’ and a `quoted | |||
There was a problem hiding this comment.
Is there really any reason to do this flattening for Quoted?
The original lines in this test are perfectly valid RST, are they not?
There was a problem hiding this comment.
good point, i didn't realise that quotes are not RST inlines. i modified the combine function as you suggested
danse
force-pushed
the
4368
branch
2 times, most recently
from
12ffe78
to
54950c4
Compare
nested inlines are not valid RST syntax, so we flatten them following some readability criteria discussed in jgm#4368.
|
thanks, work on this has been long. Unfortunately testing this once again on a set of documents i found out that it has a serious issue: the flatten function drops inline parents that are empty. the related test and the fix are in #4603. i wonder whether it makes sense to add empty images to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after the refactoring we can apply transformations to inlines in a bottom-up direction, thus it becomes possible to transform inlines flattening them according to the the readability criteria discussed in #4368