use lookupMeta* functions wherever possible #4907
Merged
+68
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2018
mb21
force-pushed
the
use-lookup-meta
branch
4 times, most recently
from
2d24f7a to
18f75e5
Compare
|
Okay, this is now changed to include the new functions in |
|
@jgm, due to d7263a7, there was a conflict again. You added So I rebased once more. Would be really good to merge this, since otherwise people will continue adding stuff that transforms the metadata inconsistently to string/inline/block/bool, etc. like just happened now. |
with lookupMeta* functions API change
|
@mb21, sorry about that. I'll merge! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on jgm/pandoc-types#51