Custom writer: give full access to doc in optional Setup function #4967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you give an example of usage, and also update the sample custom writer in data/ so we have this function? |
Custom writers can specify an optional `Setup` function. The function takes the full Pandoc document as input and should not return any value. Users can use this function to configure the writer depending on the given document's content or its metadata. Closes: jgm#4957
tarleb
force-pushed
the
custom-writer-setup
branch
from
0953964 to
f6c14df
Compare
The change allows to control the image format used to encode the image produced from dot code.
tarleb
force-pushed
the
custom-writer-setup
branch
from
f6c14df to
a29d100
Compare
|
I've added example usage to data/sample.lua; the image format used in data urls can now be controlled with the I'm honestly still unsure if a Setup function is the best way for this. I mainly chose it because it's simple. Would a global |
|
I had a change of mind and replaced the Setup function with a global variable. I think it's less confusing and easier to use. @jgm, please revert if you disagree with that change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom writers can specify an optional
Setupfunction. The functiontakes the full Pandoc document as input and should not return any value.
Users can use this function to configure the writer depending on the
given document's content or its metadata.
Closes: #4957