Use init.lua only for customizations #5287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarleb
force-pushed
the
lua-module-loading
branch
from
8634a26 to
7964e4a
Compare
The file `init.lua` in pandoc's data directory is run as part of
pandoc's Lua initialization process. Previously, the `pandoc` module was
loaded in `init.lua`, and the structure for marshaling was set-up after.
This allowed simple patching of element marshaling, but made using
`init.lua` more difficult:
- it encouraged mixing essential initialization with user-defined
customization;
- upstream changes to init.lua had to be merged manually;
- accidentally breaking marshaling by removing required modules was
possible;
Instead, all required modules are now loaded before calling `init.lua`.
The file can be used entirely for user customization. Patching
marshaling functions, while discouraged, is still possible via the
`debug` module.
tarleb
force-pushed
the
lua-module-loading
branch
from
7964e4a to
c8da49b
Compare
|
Seems like a good idea to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file
init.luain pandoc's data directory is run as part ofpandoc's Lua initialization process. Previously, the
pandocmodule wasloaded in
init.lua, and the structure for marshaling was set-up after.This allowed simple patching of element marshaling, but made using
init.luamore difficult:it encouraged mixing essential initialization with user-defined
customization;
upstream changes to init.lua had to be merged manually;
accidentally breaking marshaling by removing required modules was
possible;
Instead, all required modules are now loaded before calling
init.lua.The file can be used entirely for user customization. Patching
marshaling functions, while discouraged, is still possible via the
debugmodule.