HTML writer: emit empty alt tag in figures #5518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same text is already in the <figcaption> and screen-readers would read it twice, see jgm#4737
|
My only concern about this is that some accessibility validation software might complain about the missing alt tag. (I'm not sure about this, though.) I agree that this would improve usability with screen readers. I also agree that ultimately we need to separate alt and caption. (That's the issue for adding a proper figure type.) |
That's why it emits an empty alt tag |
|
OK, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same alt text is already in the
<figcaption>and screen-readers would read it twice, see #4737Note:
Image attr [] (s,tit)wouldn't work, since this would emit no alt tag which is invalid HTML.