Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docbook writer: Interpret links without contents as cross-references #7360

Merged
merged 1 commit into from
Feb 6, 2022

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jun 6, 2021

Copy link
Collaborator

@tarleb tarleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and sorry for the late reply! This somehow got lost.

I think this is a good and very sensible change. There is one minor issue with code style, but otherwise this seems good to go.

@tarleb
Copy link
Collaborator

tarleb commented Feb 6, 2022

For others looking at this PR, here are the docs for xref.

@jtojnar jtojnar force-pushed the docbook-xref branch 2 times, most recently from b53a1f1 to 7917a1c Compare February 6, 2022 13:51
@jtojnar jtojnar force-pushed the docbook-xref branch 2 times, most recently from a07f76c to 22409c5 Compare February 6, 2022 15:47
@jtojnar
Copy link
Contributor Author

jtojnar commented Feb 6, 2022

Hmm, turns out there was some specialization so we need helper still. Or maybe we could specify default ToString String?

@tarleb
Copy link
Collaborator

tarleb commented Feb 6, 2022

Wouldn't that (default ToString) still give a warning? We could use Language TypeApplications and write test @Text, but defining testDB5 or similar seems like the easiest solution.

@jtojnar
Copy link
Contributor Author

jtojnar commented Feb 6, 2022

Seems to work now.

@tarleb
Copy link
Collaborator

tarleb commented Feb 6, 2022

Excellent, thanks.

@jgm I'm wondering if we should hide it behind the xrefs_name extension, but I don't think that's necessary.

@tarleb tarleb merged commit 876859f into jgm:master Feb 6, 2022
@jtojnar jtojnar deleted the docbook-xref branch February 6, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants