-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docbook writer: Interpret links without contents as cross-references #7360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR and sorry for the late reply! This somehow got lost.
I think this is a good and very sensible change. There is one minor issue with code style, but otherwise this seems good to go.
For others looking at this PR, here are the docs for xref. |
b53a1f1
to
7917a1c
Compare
a07f76c
to
22409c5
Compare
Hmm, turns out there was some specialization so we need helper still. Or maybe we could specify |
Wouldn't that ( |
Seems to work now. |
Excellent, thanks. @jgm I'm wondering if we should hide it behind the |
This is what MyST does:
https://myst-parser.readthedocs.io/en/latest/using/syntax.html#targets-and-cross-referencing