Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reveal.js template: Properly set boolean config options #7403

Closed
wants to merge 1 commit into from
Closed

reveal.js template: Properly set boolean config options #7403

wants to merge 1 commit into from

Conversation

salim-b
Copy link
Contributor

@salim-b salim-b commented Jun 23, 2021

Fixes #7402

@salim-b salim-b mentioned this pull request Jun 23, 2021
Closed
@jgm
Copy link
Owner

jgm commented Jun 23, 2021

This won't work by itself -- we'd also need changes to the HTML writer, which currently sets the default values of these variables to strings. The string false counts as a true value.
I think the change I just pushed to doctemplates is a better path forward.

@salim-b salim-b closed this Jun 23, 2021
@salim-b salim-b deleted the patch-1 branch June 28, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reveal.js: Explicitly setting boolean options to false fails
2 participants
@salim-b @jgm