-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for <indexterm>s when reading DocBook #7607
Conversation
src/Text/Pandoc/Readers/DocBook.hs
Outdated
indextermNaryTextAsAttr :: Text -> Element -> Maybe (Text, Text) | ||
indextermNaryTextAsAttr n e = case findChild q e of | ||
Nothing -> Nothing | ||
Just naryEl -> Just (n, (strContent naryEl)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it's idiomatic to omit the parentheses around (strContent naryEl)
.
Should we include the pagenum attribute? What about |
A test would be nice, too! |
I don't think so. That is only used within
I will follow up with a new PR request with (partial) support for
I will included a test too. Thank you for the pointer! ☺ |
I have improved the patch. You stimulated me to go a bit further and also do the Right Thing™ with mixed-content child element of Thanks for sticking with me, @jgm ☺ |
I reworded one of my commit messages and did a |
Great, thanks. |
This PR resolves #7427. This was my first Haskell patch ever, so I'm sure that my additions, although functional, are an eyesore to seasoned Haskell coders. Please feel even more free than you usually would to correct/criticize my code.