-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build files #7696
Update build files #7696
Conversation
- basement >= 0.0.10 was 0.0.12 on stackage-18.10 - foundation >= 0.0.23 was 0.0.26.1 on stackage-18.10
6fea02a
to
f343d22
Compare
Thanks for this! Why the new constraint on mintty? We never required that before. Why is it needed now? |
mintty just got a new release and this PR moves it from 0.1.2 to 0.1.3 via the stackage lts update. I don't have access to a windows machine but the CI check failed due to a mintty-0.1.3 build error: https://github.com/jgm/pandoc/runs/4240666883 |
f79dac9
to
801854d
Compare
Ok, had to double check but mintty doesn't appear on by Retested locally and still good on Linux x86_64 Forced pushed due to missing adding the version pin on |
I'm still baffled about mintty -- where is that dependency coming from? |
I could take a look at all the cabals of all direct dependencies but it would probably by quicker for someone with access to a windows machine to get the |
Looked through every direct dependency on https://hackage.haskell.org/package/pandoc and mintty is not a 1st (direct) or 2nd (indirect) dependency of pandoc. Only 2 hackage packages that I know of that have mintty declared as a dependency are ansi-terminal-game and stack |
Here is the whole cabal-plan tree:
|
We shouldn't need to require mintty at all, then. Take it out and see what happens? |
What happens is this build failure on Windows CI: https://github.com/jgm/pandoc/runs/4240666883?check_suite_focus=true
|
Oh, it is a stack packaging issue! |
There are two paths, wait for stackage-18.18 or set a flag for mintty. |
Let's wait for 18.18. |
801854d
to
e4c5422
Compare
Dropped 2 commits, the stack update (18.10 → 18.17) and the mintty pin. Left 3 commits:
|
Tested stack update on Linux x86_64 (NixOS Unstable) with:
stack test
: