Org writer: support starting number cookies #7811
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complements #7806 by supporting writing Org ordered lists that start at a specific number.
This commit also slightly changes another thing: before, the org writer indented items to match the markers length like so
I was confused about what it should do when a counter cookie was present (should its length be counted as a marker, or ignored as part of the text like checkboxes?). But then I saw that org mode in emacs did not like this indentation anyway, because when you trigger the automatic formatting (
C-c C-c
above the list) emacs removes the extra spaces. So after this commit, the aligment is removed and the last list is written asIs this ok?
Also, is one test enough? I did wrote another one with an empty item that would not pass for mysterious reasons, only to discover that the issue was not related to this (see #7810) 🙃