Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org writer: support starting number cookies #7811

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

soficshift
Copy link
Contributor

This complements #7806 by supporting writing Org ordered lists that start at a specific number.

This commit also slightly changes another thing: before, the org writer indented items to match the markers length like so

9.  nine
10. ten

I was confused about what it should do when a counter cookie was present (should its length be counted as a marker, or ignored as part of the text like checkboxes?). But then I saw that org mode in emacs did not like this indentation anyway, because when you trigger the automatic formatting (C-c C-c above the list) emacs removes the extra spaces. So after this commit, the aligment is removed and the last list is written as

9. [@9] nine
10. ten

Is this ok?

Also, is one test enough? I did wrote another one with an empty item that would not pass for mysterious reasons, only to discover that the issue was not related to this (see #7810) 🙃

@soficshift
Copy link
Contributor Author

soficshift commented Jan 7, 2022

Oops, I was not aware of those test/writer.org tests. I think they are not run when I filter -p Org, tomorrow I will fix them

@soficshift soficshift force-pushed the org-writer-counter-cookies branch from 0ff788f to dcdc8eb Compare January 7, 2022 14:35
This complements jgm#7806 by supporting writing Org ordered lists that
start at a specific number.
@jgm jgm merged commit 45e2e0d into jgm:master Jan 7, 2022
@jgm
Copy link
Owner

jgm commented Jan 7, 2022

Looks good , thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants