Add DokuWiki table alignment for #5202 #7908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgm
reviewed
Feb 11, 2022
src/Text/Pandoc/Readers/DokuWiki.hs
Outdated
| -- choice of how to reconcile potentially different alignments in the row. | ||
| -- Here we end up assuming that the alignment of the header / first row is | ||
| -- what the user wants to apply to the whole thing. | ||
| let attrs = map (\(a, _) -> (a, ColWidthDefault)) . head $ rows |
There was a problem hiding this comment.
head makes me nervous because it's partial, even though here many1 guarantees a nonempty list.
Could we use headMay from Safe, or a pattern match, or some other non-partial function?
jgm
reviewed
Feb 11, 2022
src/Text/Pandoc/Readers/DokuWiki.hs
Outdated
Comment on lines
516
to
517
| let left = (==2) . length . filter (== B.space) . take 2 $ cellInline | ||
| let right = (==2) . length . filter (== B.space) . take 2 . reverse $ cellInline |
There was a problem hiding this comment.
Maybe more straightforward: [B.space, B.space] isPrefixOf cellInline and similarly for right with isSuffixOf?
|
Looks good, thanks! I made a couple minor comments in the code. |
damon-sava-stanley
added a commit
to damon-sava-stanley/pandoc
that referenced
this pull request
Feb 11, 2022
Don't reinvent the wheel of `isPrefixOf` and pull out some spooky `head`s.
damon-sava-stanley
added a commit
to damon-sava-stanley/pandoc
that referenced
this pull request
Feb 11, 2022
Don't reinvent the wheel of `isPrefixOf` and pull out some spooky `head`s.
damon-sava-stanley
pushed a commit
to damon-sava-stanley/pandoc
that referenced
this pull request
Feb 11, 2022
damon-sava-stanley
force-pushed
the
master
branch
2 times, most recently
from
84eca20 to
b7db72c
Compare
Within each cell, determine the cell alignment as per https://www.dokuwiki.org/wiki:syntax#tables. The current approach, as per the issue treats the first row's alignment as determining that of the entire column. Given this, it wastes some work in determining an alignment for every cell.
Don't reinvent the wheel of `isPrefixOf` and pull out some spooky `head`s.
damon-sava-stanley
force-pushed
the
master
branch
from
b7db72c to
01fce71
Compare
|
Thanks for the suggestions! I've integrated them. (Apologies for the git churn above, it's been a minute on my part.) |
|
Excellent, thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within each cell, determine the cell alignment as per
https://www.dokuwiki.org/wiki:syntax#tables. The current approach, as
per the issue treats the first row's alignment as determining
that of the entire column. Given this, it wastes some work in
determining an alignment for every cell.