Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes with pip < 6.x #2

Closed
Gillingham opened this issue Dec 4, 2015 · 3 comments
Closed

Crashes with pip < 6.x #2

Gillingham opened this issue Dec 4, 2015 · 3 comments
Assignees
Labels

Comments

@Gillingham
Copy link

Traceback (most recent call last):
  File "/virtualenv/bin/pip-review", line 40, in <module>
    from pip._vendor.packaging import version as packaging_version
ImportError: No module named packaging
pip (1.5.4)
pip-review (0.4)

Using pip-tools==0.3.6 pip-review works fine with the same old version of pip so it looks like there was a regression after the fork.

@jgonggrijp
Copy link
Owner

Yes that's right, this dependency was introduced with pull request #1. The --pre flag depends on it. I didn't realise this could break things for people using old versions of pip, sorry for not thinking that through. Is upgrading pip not an option for you?

@jgonggrijp jgonggrijp added the bug label Dec 4, 2015
@jgonggrijp jgonggrijp self-assigned this Dec 4, 2015
@Gillingham
Copy link
Author

I can upgrade, just wanted to report this as it is a bit of a regression and pip 1.5.4 is what comes stock on Ubuntu 14.04 LTS so I'm sure people will be running into this.
I guess its up to you if you want to just update install_requires in setup.py to depend on pip>=6 or figure out a work-around, for me I do all development from virtualenvs so updating pip is never an issue.

@jgonggrijp
Copy link
Owner

Thanks for reporting. I can probably make it work without depending on pip>=6, so I'll fix it that way.

Gillingham added a commit to Gillingham/pip-review that referenced this issue Dec 7, 2015
Add a test that installs pip<6.0 to trigger the error with older pip versions. Probably shouldn't merge this until it's fixed unless you don't mind the builds failing :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants