-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement pip-review on top of pip list --outdated #32
Comments
That's great! I think one pull request is sufficient, because (I believe) all these issues are tightly coupled. Please be prepared for some review rounds before it gets accepted. This is something I want to get right from the first moment and I happen to be opinionated on the matter. I should emphasize that I'm glad you took up on this, though. ;-) |
Updated the title and the opening post because of #41. |
Not going to do this myself, but this should be trivial with the
|
And then I read the PR and find out that |
It's complicated. |
New related PR: #53. |
Closed in version 1.0. |
Instead of using
pip freeze
to get a list of installed packages and then running custom code to fetch the latest version from pypi.python.org, simply callpip list --outdated
to get all the necessary information at once. Forward arguments like--pre
,--local
and--user
directly to the call topip list --outdated
.Will allow us to replace the
load_pkg_info
,guess_pkg_name
,get_pkg_info
,latest_version
,get_latest_versions
andget_installed_pkgs
by a single short function that does the call topip list --outdated
.Will resolve #6, #18, #21 and #27 at once.
After this change, pip-review will formally depend on pip>=1.3. This is the first version of pip that shipped with the
list
subcommand and the corresponding--outdated
option.The text was updated successfully, but these errors were encountered: