-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified the logic used for importing Python version specific packages #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR, @kshitij10496 (which is your given name, Kshitij or Saraogi?). It does look a bit neater this way.
With one more small change, it could look a little bit neater still. Would you mind adding another commit for that? Cheers.
pip_review/__main__.py
Outdated
|
||
from pkg_resources import parse_version | ||
from packaging import version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're at it, to complete the neatness, would you mind moving these two lines above the if/else block? Thanks in advance.
I am happy to contribute. BTW, my first name is Kshitij. |
In this case I don't mind a squash, but in general it is better to leave history unchanged once it has been published. Do what you prefer, I'll merge it either way. |
I couldn't agree more. |
Oops, I almost missed this: this project uses git-flow, incidentally by the same author as the original pip-tools. Basically, this means that your branch should be merged into I manually merged your branch into |
@jgonggrijp That's fine by me. |
Hey @jgonggrijp
Thank you for this package.
In this PR, I have tried to unify the import statements for Python version specific packages into a single conditional clause.