Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last_answer to the Interactive mode #70

Merged
merged 2 commits into from
Mar 21, 2020

Conversation

cherichy
Copy link

@cherichy cherichy commented Oct 7, 2018

I don't want to type Y or N everytime, so just push Enter for the last answer.

I don't want to type Y or N everytime, so just push Enter for the last answer.
Copy link
Owner

@jgonggrijp jgonggrijp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request! Would you mind adding two more things?

  1. Show the default answer in the default prompt. For example by appending [y] if the previous answer was y and [n] if the previous answer was n.
  2. Add a test to tests/review.t so that we can confirm that the feature still works in the future.

Thanks in advance!

@cherichy
Copy link
Author

cherichy commented Oct 8, 2018

I have added the default answer, but I am not familiar with the syntax of the test file. So I did not change the test file. Sorry about that.

@jgonggrijp
Copy link
Owner

No problem, thanks for your work so far. I'll take it from here. If somebody else is faster, please go ahead.

jgonggrijp added a commit that referenced this pull request Mar 21, 2020
@jgonggrijp jgonggrijp merged commit 7540eef into jgonggrijp:develop Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants