Fixing constraints bug and modifying README #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the path of the constraints file so pip does use it.
Change so the command to execute is now `pip install -U package_to_update` instead of `pip install package_to_update==latest-version` which would ignore the exclusions of the constraints file.
jgonggrijp
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
This looks good to me. The regression test at the end is failing, but only because that test didn't take into account that downgrading pip might also downgrade other packages (cram is crap for this job; see #61).
There's one more detail that I suggest polishing a bit. See below. In any case, thanks for the fix!
Co-authored-by: Julian Gonggrijp <dev@juliangonggrijp.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the problems reported on this issue