Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update missing translations #88

Merged

Conversation

tomekknapczyk
Copy link
Contributor

Removed fallback to default locale when updating translations.

If we have an object without some translation (en -> exists, pl -> does not exist) and we try to update it with new values, then we run into a fallback issue.
For empty pl translation, method translate will return default en translation and update it with new pl value which is incorrect.

Once changed, during import the translate method will not return a fallback value and will only update the specified locale.

@jgrygierek jgrygierek added the bug Something isn't working label Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.08%. Comparing base (731c8a7) to head (c69ecd6).
Report is 2 commits behind head on master.

❗ Current head c69ecd6 differs from pull request most recent head 3136b52. Consider uploading reports for the commit 3136b52 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #88      +/-   ##
============================================
+ Coverage     97.07%   97.08%   +0.01%     
- Complexity      179      180       +1     
============================================
  Files            29       29              
  Lines           478      480       +2     
============================================
+ Hits            464      466       +2     
  Misses           14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgrygierek
Copy link
Owner

@tomekknapczyk Hi, thanks for your PR. I will check it soon. Can you fix code style?

@jgrygierek
Copy link
Owner

jgrygierek commented Mar 28, 2024

@tomekknapczyk can you resolve conflicts? And one thing: in this package instead of id field I use entity field. Please check ImportControllerTraitTest.

@jgrygierek jgrygierek merged commit 658a0cb into jgrygierek:master Apr 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants