Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero Sizes should be configurable variables #2739

Closed

Comments

@hammadzz
Copy link

hammadzz commented Dec 12, 2019

Like done with section sass these hero sizes should be variables:

// Sizes
&.is-small
.hero-body
padding-bottom: 1.5rem
padding-top: 1.5rem
&.is-medium
+tablet
.hero-body
padding-bottom: 9rem
padding-top: 9rem
&.is-large
+tablet
.hero-body
padding-bottom: 18rem
padding-top: 18rem

See section sass:

$section-padding: 3rem 1.5rem !default
$section-padding-medium: 9rem 1.5rem !default
$section-padding-large: 18rem 1.5rem !default

I can make a pull request on it if this seems like something many others would also want.

@IvanFrescas
Copy link
Contributor

Hi, I'm looking to make my first contributions, can I work on this issue?

@kaleabMelkamu
Copy link

kaleabMelkamu commented Dec 14, 2019 via email

@IvanFrescas
Copy link
Contributor

I made the changes and made the pull request.
Any feedback is welcome. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment