Fix Indeterminate Progress Bar animation in Firefox. Fixes #2258 #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Is there any update on when will this PR get merged? |
|
@jgthms is there any chance this PR lands in the code? |
|
Thanks a lot, that was fast! 👍 |
This was referenced Mar 13, 2020
This was referenced Mar 25, 2020
This was referenced Apr 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix | documentation fix.
Issue #2258
Proposed solution
Change CSS precedence of .progress:indeterminate::-moz-progress-bar and .progress.is-#{$name}::-moz-progress-bar.
This allow indeterminate bars to be transparent on Firefox, and allow background-image fill to be visible, which will restore the bar animation.
Tradeoffs
I didn't detect any issues.
Testing Done
Page https://bulma.io/documentation/elements/progress/#indeterminate tested locally on Firefox 63.0.3 and Chrome 71.0.3578.80