make focus behave like hover for the navigation. #2321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using :focus-within for dropdown menu.
This is a improvement.
The navigation bar behaves with the keyboard (tab+focus) the same like when using the mouse. Before the change the dropdown didn't work with the keyboard, now it works.
Proposed solution
A dropdown menu will expand when using the keyboard (didn't expand before).
The highlighting on focus will work like on hovering
Tradeoffs
None that I can think of. No additional classes and coupling. No JavaScript necessary.
Testing Done
I've changed the sass file and tested it locally with the Bulma documentation. I can now tab trough the navigation. In Chrome there is a blue standard highlighting for the active menu item when I tab trough (standard browser behavior). The Menu items focused now appear with light grey background - same as hovering. When I reach the "More" menu item, is expands. I can also use shift-tab to move back through the menu.
Screenshot of test attached.
I've used the same changes on my personal homepage.