Fix 'align' attribute in td/th being ignored- Fixes #2414 #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
changed the title
ghost
changed the title
This was referenced Mar 13, 2020
This was referenced Mar 25, 2020
This was referenced Apr 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix.
Fixes issue #2414:
There are multiple
<td>and<th>selectors which settext-align:lefttaking precedence over the elements' attributealign(from HTML versions lower than HTML5)Proposed solution
From
<th>and<td>selectors which settext-aligndeselect elements with attributealign.Tradeoffs
None detected
Testing Done
Tested in Firefox 66.0 and Chrome 73.0.3683.