Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(panel): use $panel-colors variable #2664

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

Gomah
Copy link
Contributor

@Gomah Gomah commented Oct 20, 2019

This is a bugfix.

When importing the panel sass file individually, it throws an error as the $message-colors variable is not defined.

Proposed solution

I think panel.sass should have the same logic as message.sass & declare a $panel-colors variable at the top.

Changelog updated?

No.

@jgthms jgthms merged commit d1fb5d3 into jgthms:master Oct 21, 2019
@Gomah Gomah deleted the fix/panel-colors-variables branch October 21, 2019 19:47
@pokonski
Copy link

pokonski commented Dec 9, 2019

It's been two months since this fix was merged, do you have plans to release it @jgthms ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants