Fixes #2773 - Import derived-variables in mixins.sass #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Didel
changed the title
|
Just upgraded from 0.7 hoping that all the kinks would've been resolved as v0.8.0 has been out for almost a year now. The docs link to the responsive mixins that are available to use: https://bulma.io/documentation/overview/responsiveness/ |
dbryar
approved these changes
Sep 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix for #2773 .
Proposed solution
Import the derived-variables in mixins.scss too.
This will ensure you don't get compiler errors when you only need to import mixins.scss.
Tradeoffs
None. The dependency to the derived-variables stylesheet was already there (see original issue), this only makes that dependency explicit and prevents compiler errors.
Testing Done
I have tested this change against the how-to-reproduce in #2773 . Without this change, I get a compiler error. With this change I don't.
Changelog updated?
No.