-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexbox helpers #3047
Flexbox helpers #3047
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think sticking to the exact property name is better in this case, to avoid ambiguity.
Also, can you rename the file to flexbox.sass
?
Thanks.
flex helpers need responsive options too like -mobile, -tablet, -desktop ..... so naming would be quite long |
This is a new feature.
When using Bulma I often use
is-flex
but the modifiers you'll want to use are missing such asjustify-content: space-between
. I found a couple of issues/PRs such as the most recent #3008 which suggest adding flexbox helpers.Proposed solution
I've added most flexbox options such as
is-justify-content-space-between
. Perhaps naming can be improved as some are quite long (the suggestedis-justified-space-between
or{has-,is-}justify-between
are probably be better), and perhaps some hardly used values can be removed.So it's not done yet, but wanted to get some feedback early on.
Tradeoffs
Testing Done
None.
Changelog updated?
No.