Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexbox helpers #3047

Merged
merged 5 commits into from
Aug 27, 2020
Merged

Flexbox helpers #3047

merged 5 commits into from
Aug 27, 2020

Conversation

mrm
Copy link
Contributor

@mrm mrm commented Jul 17, 2020

This is a new feature.

When using Bulma I often use is-flex but the modifiers you'll want to use are missing such as justify-content: space-between. I found a couple of issues/PRs such as the most recent #3008 which suggest adding flexbox helpers.

Proposed solution

I've added most flexbox options such as is-justify-content-space-between. Perhaps naming can be improved as some are quite long (the suggested is-justified-space-between or {has-,is-}justify-between are probably be better), and perhaps some hardly used values can be removed.

So it's not done yet, but wanted to get some feedback early on.

Tradeoffs

Testing Done

None.

Changelog updated?

No.

Copy link
Owner

@jgthms jgthms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sticking to the exact property name is better in this case, to avoid ambiguity.
Also, can you rename the file to flexbox.sass?
Thanks.

sass/helpers/flex.sass Outdated Show resolved Hide resolved
sass/helpers/flex.sass Outdated Show resolved Hide resolved
sass/helpers/flex.sass Outdated Show resolved Hide resolved
sass/helpers/flex.sass Outdated Show resolved Hide resolved
sass/helpers/flex.sass Outdated Show resolved Hide resolved
sass/helpers/flex.sass Outdated Show resolved Hide resolved
@Rome00
Copy link

Rome00 commented Aug 20, 2020

flex helpers need responsive options too like -mobile, -tablet, -desktop ..... so naming would be quite long .is-justified-space-between-tablet .is-justify-between-tablet will be better or
something like .is-flex-between for justify-content and .is-vflex-between for align-items.

@service-paradis
Copy link
Contributor

service-paradis commented Aug 20, 2020

This PR would fix #3008, #3078 and #3071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants