Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Features: Switch for Checkbox & Timeline #544

Closed
wants to merge 5 commits into from
Closed

New Features: Switch for Checkbox & Timeline #544

wants to merge 5 commits into from

Conversation

Wikiki
Copy link
Contributor

@Wikiki Wikiki commented Mar 5, 2017

Add sass rules to display checkboxes as switches just by adding “switch” class. issue #538
screen shot 2017-03-03 at 10 37 57

HTML code:

<label class="switch">
    <input type="checkbox">
    <span>Label</span>
</label>

Add Timeline component : issue #422
Image of Timeline

gaetan-hexadog and others added 2 commits March 5, 2017 15:31
Add sass rules to display checkboxes as switches just by adding “switch” class
Easy display a Timeline
@Wikiki Wikiki changed the title Add Switch Display mode to Checkbox New Features: Switch for Checkbox & Timeline Mar 5, 2017
@robin900
Copy link
Contributor

robin900 commented Mar 9, 2017

@Wikiki Would you be willing to submit this PR as two separate PRs, one for the switch issue and one for the timeline component. I suggest this because I think the switch code will pass muster and get approved much more quickly. The timeline component likely needs additions to the documentation to illustrate its usage and provide a local testbed for the timeline styles; and that will likely take some time to write.

@Wikiki
Copy link
Contributor Author

Wikiki commented Mar 9, 2017

Hi @robin900 ,

I're right. But How can I split it in two PRs ? It's the first time a do a PR for an open source project and it's not clear to me.

Thanks

@yo7
Copy link
Contributor

yo7 commented Mar 9, 2017

Make commits for each feature then do a PR one by one.

@Wikiki Wikiki closed this Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants