Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website(fix): reject empty secrets #2494

Merged
merged 1 commit into from
Oct 9, 2024
Merged

website(fix): reject empty secrets #2494

merged 1 commit into from
Oct 9, 2024

Conversation

jhaals
Copy link
Owner

@jhaals jhaals commented Oct 9, 2024

fixes #2289

Signed-off-by: Johan Haals <johan.haals@gmail.com>
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.54%. Comparing base (c004f37) to head (0bc38d1).
Report is 162 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2494   +/-   ##
=======================================
  Coverage   73.54%   73.54%           
=======================================
  Files           7        7           
  Lines         567      567           
=======================================
  Hits          417      417           
  Misses        117      117           
  Partials       33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhaals jhaals merged commit 7dd6c64 into master Oct 9, 2024
15 checks passed
@jhaals jhaals deleted the fix-empty-secret branch October 9, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow empty note
1 participant