Contribution back to Spring Framework

[artembilan]

Hi, @jhalterman !

Your work looks good and I have to admit that it resolve my additional type parameter issue. At least at a glance with smoky test.

I see you mention in your TypeResolver the org.springframework.core.GenericTypeResolver.
So, how about to contribute it back to Spring?

We have there several issues with generics on Lambdas as well.

Anyway we will consider to use your work somehow to make our GenericTypeResolver more stable.

Thank you very much!

[jhalterman]

Sure - I'll have a look and see what I can do. TypeTools was initially based on some things in GenericTypeResolver but the code has been refined a bit since then, including support for various corner cases. I'll send over a pull request when I get a chance...

[jhalterman]

@artembilan For Spring I would consider using ASM as a fallback for reading the lambda's method signature instead of ConstantPool since ConstantPool is only available on open/oracle JDK runtimes. ASM should work more broadly, but will cost a bit more in overhead to read in the class definition.

[artembilan]

@jhalterman, I've raised JIRA issue to track it and have a discussion with SF team: https://jira.spring.io/browse/SPR-12525.

Thank you one more time!
Looking forward for the contribution!

/CC: @jhoeller

[jhalterman]

Closing for now.