fix check for streams that do not use a stream slicer (airbytehq#18080)

* fix check for streams that do not use a stream slicer * increment version and changelog before publish
jhammarstedt · Oct 31, 2022 · 62a85c1 · 62a85c1
1 parent f7a81a8
commit 62a85c1
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/airbyte-cdk/python/CHANGELOG.md b/airbyte-cdk/python/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.1.102
+
+- Low-code: Fix check for streams that do not define a stream slicer
+
 ## 0.1.101
 
 - Low-code: $options do not overwrite parameters that are already set

diff --git a/airbyte-cdk/python/airbyte_cdk/sources/declarative/stream_slicers/single_slice.py b/airbyte-cdk/python/airbyte_cdk/sources/declarative/stream_slicers/single_slice.py
@@ -56,4 +56,4 @@ def get_request_body_json(
         return {}
 
     def stream_slices(self, sync_mode: SyncMode, stream_state: Mapping[str, Any]) -> Iterable[StreamSlice]:
-        return [dict()]
+        yield dict()
diff --git a/airbyte-cdk/python/setup.py b/airbyte-cdk/python/setup.py
@@ -15,7 +15,7 @@
 
 setup(
     name="airbyte-cdk",
-    version="0.1.101",
+    version="0.1.102",
     description="A framework for writing Airbyte Connectors.",
     long_description=README,
     long_description_content_type="text/markdown",

diff --git a/airbyte-cdk/python/unit_tests/sources/declarative/iterators/test_only_once.py b/airbyte-cdk/python/unit_tests/sources/declarative/iterators/test_only_once.py
@@ -10,4 +10,5 @@ def test():
     iterator = SingleSlice(options={})
 
     stream_slices = iterator.stream_slices(SyncMode.incremental, None)
-    assert stream_slices == [dict()]
+    next_slice = next(stream_slices)
+    assert next_slice == dict()