Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix - do not update the deleted items on env.step() #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

askuric
Copy link

@askuric askuric commented Aug 5, 2023

Hi @jhavl,

This is a quick PR. I've stumbled upon a problem when I add a mesh file to the environment and remove it later on.

...
env.add(poly_mesh)
...
env.remove(poly_mesh)
...
env.step()

basically the for loop inisde the env.step() does not check if the object has been deleted or not. So I've added it.
With this change the above code work properly.

@KuabeM
Copy link

KuabeM commented Oct 30, 2023

Stumbled upon the same issue and tested this fix. Works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants