Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leading slash for paths to be retrieved #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KuabeM
Copy link

@KuabeM KuabeM commented Oct 10, 2023

The leading slash breaks windows compatibility as paths starting with /C:/ can't be resolved on windows, as mentioned here f6c8cde#r116060265. Removing this leading slash on Linux does not change the behavior, paths like /home/... and //home/... can both be resolved.

Here's the output of the commented print call for self.path[10:] on Linux:

Retrieving file: /home/<redacted>/meshes/link_base_1.STL

And here's the output of the commented print call for self.path[9:]:

Retrieving file: //home/<redacted>/meshes/link_base_1.STL

Is there any reason to keep this for *nix platforms? If yes I'd be happy to add a conditional parsing.

The leading slash breaks windows compatibily as paths starting with
`/C:/` can't be resolved on windows.
@kappa95
Copy link

kappa95 commented Oct 19, 2023

This solved my issue (ISSUE #50)

@Muhammadsgit
Copy link

Solved my issue as well. Thanks!

@kongyuanchao
Copy link

My issue has been solved. Big thanks!

@apojomovsky
Copy link

apojomovsky commented Apr 1, 2024

Thanks @KuabeM , this seem to have solved the issue we were all facing when attempting to load meshes when running a simulation.

@jhavl is there anything that we could do to help getting these changes merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants