Remove leading slash for paths to be retrieved #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leading slash breaks windows compatibility as paths starting with
/C:/
can't be resolved on windows, as mentioned here f6c8cde#r116060265. Removing this leading slash on Linux does not change the behavior, paths like/home/...
and//home/...
can both be resolved.Here's the output of the commented
print
call forself.path[10:]
on Linux:And here's the output of the commented
print
call forself.path[9:]
:Is there any reason to keep this for *nix platforms? If yes I'd be happy to add a conditional parsing.