Add a few more specs to outstanding_balance_integration_spec #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates outstanding_balance to use the value of "reimbursements" when determining the payment total. Previously the value of an order's refunds was used both for representing the money returned to the customer as well as the reduced "adjusted total" of the order (which we expected to be paid). This was wrong in a number of cases. This commit updates outstanding_balance to use the value of reimbursements for calculating the "adjusted total" of the order. This allows all cases to (at least) be represented properly. This better matches the best practice double-entry bookkeeping style. Reimbursements are created when going through the refund system so this should continue to work for cases where refunds where made through the returns system.
Created a spec to simulate the behavior listed in solidusio#1475 in order to properly fix the issue.
…ulation" This reverts commit da0f0e73ed0fd01ec6188757063ea26918c473e8.
Update this spec to match the values it currently returns. I changed the values in this spec into what values we got from the system, which isn't ideal, but I think these values make sense. We have a payment for an amount and a refund for the same amount, so payment total should be zero. Because the order is cancelled, this is the state we want, and the outstanding balance should be zero.
jhawthorn
force-pushed
the
outstanding_balance_omnibus
branch
3 times, most recently
from
b0d21bc to
6a031da
Compare
|
Opened as a PR against solidusio/solidus: solidusio#2051 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.