Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a method configGetOriginal which will return the original config data. #197

Merged
merged 3 commits into from
Aug 28, 2018

Conversation

aritomelo
Copy link
Contributor

Motivation:

  • DrupalDriver configGet() method which uses the Drupal "get" method to retrieve the configuration. The problem is that the latter takes override into account which means that when the Behat extension restores the config backups, it will save the override instead of the original config value.

By providing this method, when the Behat extension restores the config it will take the original data from configuration (eg.:settings.php).

@jhedstrom
Copy link
Owner

How would this be used? It's hard to tell since it only adds the method in this PR, but it isn't used...

@upchuk
Copy link
Contributor

upchuk commented Aug 28, 2018

@jhedstrom This one fixes #194. And it will be used by the extension, see issue jhedstrom/drupalextension#501. A PR will follow also for that.

@aritomelo
Copy link
Contributor Author

@jhedstrom Hi mate the second PR can be found here: jhedstrom/drupalextension#503

@jhedstrom jhedstrom merged commit 22ee1f3 into jhedstrom:master Aug 28, 2018
@jhedstrom
Copy link
Owner

Cool, that makes sense. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants