Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Drupal 8.1. #266

Merged
merged 3 commits into from
May 5, 2016

Conversation

pfrenssen
Copy link
Collaborator

Drupal 8.1 is going to be released soon. It's using Symfony 2.8. We need to update our dependencies to support this, or this will cause conflicts in projects that depend both on Drupal core and Drupal extension. One example is my fork of Drupal-project: https://github.com/pfrenssen/drupal-project.

@pfrenssen
Copy link
Collaborator Author

Interesting failure. Seems to be in Symfony itself?

@jhedstrom
Copy link
Owner

This failure has cropped up before. It's quite confusing, but the issue is that 8.1 specifies symfony 2.8.2, but in 2.8.3 some underlying interfaces were modified. So when we pull down ~2.8 we get the newer version that is incompatible with the version in core.

@pfrenssen
Copy link
Collaborator Author

Great, thanks for the hint! I'll pick this back up tomorrow and will update the version range.

@pfrenssen
Copy link
Collaborator Author

On the suggestion of @catch56 I'll also make an issue to update Drupal core to Symfony 2.8.3.

@pfrenssen
Copy link
Collaborator Author

Created core issue to update to the latest version of Symfony: https://www.drupal.org/node/2702677.

@pfrenssen
Copy link
Collaborator Author

So it seems that we are seeing several test failures related to the new release of drush: it no longer supports PHP 5.4, nor Drupal 6.

@jhedstrom seeing that Drupal 6 is now officially obsolete, what is your opinion on this? Do we make an effort to keep the test suite green on Drupal 6 / PHP 5.4? Do we move them to "Allowed failures"? Or do we maybe drop support completely?

Over time the interest in Drupal 6 / PHP 5.4 will drop, while maintenance effort will rise. For me personally I dread having to deal with D6 related stuff to bring this issue to completion. But I'll do whatever necessary :) It's critical for our project to have full Drupal 8.1 support in two weeks time.

There are some compatibility problems between Symfony 2.8.2 and higher.

See https://www.drupal.org/node/2702677.

This partially reverts 14cc437.
@pfrenssen
Copy link
Collaborator Author

So we were apparently following the master branch of Drush, and they released an early alpha version of Drush 9. This doesn't yet affect us for the time being, I simply updated the Travis config to stick with Drush 8. We can postpone the D6 drama for a few months :)

@pfrenssen
Copy link
Collaborator Author

So this is now compatible with Drupal 8.1 as it stands now. As soon as https://www.drupal.org/node/2702677 is in we should update our composer.json for our D8 tests accordingly.

@jhedstrom
Copy link
Owner

I simply updated the Travis config to stick with Drush 8.

👍

@jhedstrom jhedstrom added this to the 3.2.0 release milestone Apr 8, 2016
@jhedstrom
Copy link
Owner

I reran the tests, but now drush runserver is on the fritz (drush-ops/drush#2090). This is like whack-a-mole

@jhedstrom jhedstrom merged commit 5ccf930 into jhedstrom:master May 5, 2016
@jhedstrom
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants