-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Drupal 8.1. #266
Conversation
Interesting failure. Seems to be in Symfony itself? |
This failure has cropped up before. It's quite confusing, but the issue is that |
Great, thanks for the hint! I'll pick this back up tomorrow and will update the version range. |
On the suggestion of @catch56 I'll also make an issue to update Drupal core to Symfony 2.8.3. |
Created core issue to update to the latest version of Symfony: https://www.drupal.org/node/2702677. |
So it seems that we are seeing several test failures related to the new release of drush: it no longer supports PHP 5.4, nor Drupal 6. @jhedstrom seeing that Drupal 6 is now officially obsolete, what is your opinion on this? Do we make an effort to keep the test suite green on Drupal 6 / PHP 5.4? Do we move them to "Allowed failures"? Or do we maybe drop support completely? Over time the interest in Drupal 6 / PHP 5.4 will drop, while maintenance effort will rise. For me personally I dread having to deal with D6 related stuff to bring this issue to completion. But I'll do whatever necessary :) It's critical for our project to have full Drupal 8.1 support in two weeks time. |
There are some compatibility problems between Symfony 2.8.2 and higher. See https://www.drupal.org/node/2702677. This partially reverts 14cc437.
So we were apparently following the master branch of Drush, and they released an early alpha version of Drush 9. This doesn't yet affect us for the time being, I simply updated the Travis config to stick with Drush 8. We can postpone the D6 drama for a few months :) |
So this is now compatible with Drupal 8.1 as it stands now. As soon as https://www.drupal.org/node/2702677 is in we should update our composer.json for our D8 tests accordingly. |
👍 |
I reran the tests, but now drush runserver is on the fritz (drush-ops/drush#2090). This is like whack-a-mole |
Thanks! |
Drupal 8.1 is going to be released soon. It's using Symfony 2.8. We need to update our dependencies to support this, or this will cause conflicts in projects that depend both on Drupal core and Drupal extension. One example is my fork of Drupal-project: https://github.com/pfrenssen/drupal-project.