Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic feedback selection, config cleanup #4

Merged
merged 38 commits into from
Dec 9, 2022

Conversation

malthee
Copy link
Collaborator

@malthee malthee commented Dec 7, 2022

  • Implemented automatic and random feedback selection based on feedbacks received. Students who have received less feedbacks on submissions and reviews are more likely to be selected.
  • Added save mechanism to CSV for the count of feedbacks a student has received.
  • Integrated save-feedback command as prompt into mail command.
  • Moved the prompt of some properties into the ConfigHandler and added backing fields to avoid code duplication.
  • Renewed readme.md with new functionality, better readability and tutorial for shared tutor work.
  • Name of Moodle authorization cookie can now be set through the ConfigHandler.

+ Avoids duplicated code every time a property is needed
+ Properties backed by fields
Avoid having problems if name changes
@malthee
Copy link
Collaborator Author

malthee commented Dec 7, 2022

Not ready for merge yet, fixing tests

@malthee
Copy link
Collaborator Author

malthee commented Dec 7, 2022

Tried executing pipeline locally but it succeeded, don't know whats wrong here

@malthee
Copy link
Collaborator Author

malthee commented Dec 8, 2022

Ready to merge, fixed the test bug by excluding the java.nio.file.Files library, which caused an UnsatisfiedLinkError because the classloader has already loaded an instance of it.

@jheinzel jheinzel merged commit 39da7d4 into main Dec 9, 2022
@malthee malthee deleted the feature/review-chooser branch December 13, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants