Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use context #8

Merged
merged 4 commits into from
Aug 2, 2022
Merged

Use context #8

merged 4 commits into from
Aug 2, 2022

Conversation

dillonstreator
Copy link

@dillonstreator dillonstreator commented Jul 1, 2022

this is a breaking change and would require a v2 tag

@dillonstreator
Copy link
Author

@jheth thoughts on this?

@dillonstreator
Copy link
Author

@jheth can we get this in?

@jheth
Copy link
Owner

jheth commented Aug 2, 2022

Hey @dillonstreator sorry for the delay. yes, this looks good.

@jheth
Copy link
Owner

jheth commented Aug 2, 2022

@dillonstreator out of curiosity, what was the reason you needed this? In general I support passing context around but what problem did this solve for you?

@dillonstreator
Copy link
Author

Propagating request cancelation and APM with datadog

@jheth
Copy link
Owner

jheth commented Aug 2, 2022

Excellent. I was actually hoping Datadog was a reason for this. 👍

@jheth jheth merged commit b3c4bc5 into jheth:master Aug 2, 2022
@jheth
Copy link
Owner

jheth commented Aug 2, 2022

@dillonstreator v2.0.0 tag created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants