Collected patches + update build to support Apple Silicon; add help string; update README #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Executing `screenresolution list` can result in the command prompt being displayed immediately after the last resolution in the list. Add a trailing line break so the command prompt is displayed on a new line.
Currently, the _compareCFDisplayModes method uses CGDisplayModeRef* as the first and second parameters, in alignment with the CFComparatorFunction type alias declaration expecting an UnsafeRawPointer. But CGDisplayModeRef is already a pointer to CGDisplayMode and doesn't need a reference again to work as a comparator. Doing so also introduces extra referencing and dereferencing that can be avoided. Update the method signature to pass CGDisplayModeRef directly.
Newer versions of MacOS use a scaling factor (like 2x, which is the default for newer MacBooks), leading to the default mode being half the native resolution of the display. In such cases, it would be desirable to fetch the maximum resolution supported by the display (native resolution). Add a getMax option to fetch this information.
andrew95qq
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.