Skip to content

Commit

Permalink
Don't watch for changes at e2e script and add e2e:open. (#657)
Browse files Browse the repository at this point in the history
  • Loading branch information
mshima authored Apr 30, 2022
1 parent 6a44c40 commit 8f8597e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ionic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ jobs:
uses: cypress-io/github-action@v2
with:
browser: chrome
command: npm run e2e:ci
command: npm run e2e
working-directory: ${{ github.workspace }}/ionic4j
- name: 'E2E: Store failure screenshots'
uses: actions/upload-artifact@v3
Expand Down
10 changes: 5 additions & 5 deletions generators/ionic/resources/base/angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,7 @@
"builder": "@cypress/schematic:cypress",
"options": {
"devServerTarget": "app:serve",
"watch": true,
"headless": false,
"browserTarget": "chrome"
"browser": "chrome"
},
"configurations": {
"production": {
Expand Down Expand Up @@ -170,14 +168,16 @@
}
}
},
"cypress-run": {
"cypress-open": {
"builder": "@cypress/schematic:cypress",
"options": {
"devServerTarget": "app:serve"
},
"configurations": {
"production": {
"devServerTarget": "app:serve:production"
"devServerTarget": "app:serve:production",
"watch": true,
"headless": false
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion generators/ionic/resources/base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"scripts": {
"build": "ionic build",
"e2e": "ng e2e",
"e2e:ci": "ng run app:cypress-run --browser chrome",
"e2e:open": "ng run app:cypress-open",
"lint": "ng lint",
"ng": "ng",
"prettier": "prettier --write \"{,e2e/**/,src/**/}*.{js,json,html,md,ts,css,scss,yml}\" --loglevel silent",
Expand Down

0 comments on commit 8f8597e

Please sign in to comment.