-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to micronaut 2.0.0 #108
update to micronaut 2.0.0 #108
Conversation
Using my local setup (latest main generator and gradle 6.5) the server tests are running just fine |
generators/server/templates/src/main/java/package/security/BcryptPasswordEncoder.java.ejs
Show resolved
Hide resolved
@atomfrede I manually updated a now-outdated version of the sample app to Micronaut 2 for our comparisions project. It may be of some help: https://github.com/micronaut-projects/micronaut-comparisons/tree/master/jhipster-sample-app-micronaut-2 |
Small heads up, I have generated an application with gradle and jwt, it works fine (build, run, tests). Seems the incremental build support does not work fine with the annotation processing or something else we have. Need to check. Maven seems to have a dependency problem, I think I already know, just need to fix it. Using oauth there is a NPE in the DefaultUserDetailsMapper, need to check if it is due to our configuration. Furthermore I am a little confused. In the RC1 documentation it is mentioned that EDIT: But of course I am testing against latest main generator master which has already e.g. updated gradle, but I guess thats unrelated. |
generators/server/templates/src/test/java/package/security/jwt/JWTFilterTest.java.ejs
Outdated
Show resolved
Hide resolved
981a15b
to
161e049
Compare
I will check why the generated jar is not starting using |
161e049
to
790b6ba
Compare
@JasonTypesCodes If you have time can you test it maybe? I have generated the gradle-jwt-angular sample and did test. integrationTest and e2e, all green. It seems to be a timeout error on the ci, not sure why exactly. |
@atomfrede Sure thing. I'll give it a go this evening. |
Thanks very much! |
@atomfrede I've tried it a few different ways on my local machine and I'm not getting any failures. I did notice that we aren't using |
@atomfrede That didn't work, but I did notice this when watching the GH Action run:
I don't recall seeing that on my machine. I'll look into that a bit |
Yes I have sent it too and wondering why as it also don't happen when doing it locally. |
I've recreated it a couple times on my machine using the |
I spoke too soon. I just witnessed it happening without a background process. I can't dedicate much time to this right now, but this reminds me of an issue we had at some point in Micronaut 1.3.x with Liquibase Migrations. (cc @ilopmar) Full Stack Trace is:
|
Thanks @JasonTypesCodes for taking a look. I will try to dig deeper whats going on. |
Some more small insights. When using maven, there seems to be the jackson version is not correct (2.10.4). This results in e.g. method not found exception in the JWTTest. Updating it to 2.11 (as it is already in gradle) result sin a different error (not found exception). |
235cfe1
to
424a5e1
Compare
Small update:
|
I'll take another stab at figuring this out this afternoon. This is great work @atomfrede ! |
Thanks @JasonTypesCodes ❤️ Testing manually oauth works just fine. |
0263612
to
e6133ec
Compare
I would say let's merge it. I can take care of updating the blueprint to the 6.10 main generator release later today so we can have heroku deployment merged afterwards. |
Bounty claimed https://opencollective.com/generator-jhipster/expenses/23958 |
This PR updates
Open Issues
Updates #89