Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heroku deployement for app names starting with "p" or later #128

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

atomfrede
Copy link
Member

@atomfrede atomfrede commented Jul 24, 2020

When building a jar with maven we have two jars:

  • xyz.jar (which is the exeutable jar) and
  • original-xyz.jar

The procfile just started *.jar in case the app name was before o everything worked fine. In case the original jar was lexicographical before the executable jar it was tried to start that. In the main generator we don't have that problem as the original jar is named xyz.jar.original so we could just reference *.jar.

closes #126

@atomfrede atomfrede added the bug 🐞 Something isn't working label Jul 24, 2020
@atomfrede
Copy link
Member Author

e2e tests are failing because the selenium driver has a new version only compatible with a newer chrome version. I suspect the release will be published to the package repositories soon, so maybe just ignore the failing e2e tests for now

1 similar comment
@atomfrede
Copy link
Member Author

e2e tests are failing because the selenium driver has a new version only compatible with a newer chrome version. I suspect the release will be published to the package repositories soon, so maybe just ignore the failing e2e tests for now

@atomfrede atomfrede merged commit 54b9d9d into jhipster:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Production: Deployment to Heroku failed
1 participant