-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AdminUserDTO and the PublicUserResource #216
Conversation
Thanks @gzsombor ! It looks like the gradle-jwt-react sample end to end UI tests need to be checked with these updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @gzsombor for contributing this. @JasonTypesCodes We should now decide when to do the last/final release based on 6.x as this feature is already part of 7.x if I am not mistaken (and we will not backport it).
generators/server/templates/src/main/java/package/service/dto/AdminUserDTO.java.ejs
Outdated
Show resolved
Hide resolved
I think the problem is that this blueprint still use the old - 6.x templates - for the frontend generation. |
I picked up the 1.0 conversation in its issue (#189) |
Sure, I will try to rebase my patch |
b20cd2f
to
7a4582c
Compare
@gzsombor Can you please resolve conflicts or close? |
7a4582c
to
2946c89
Compare
I've rebased the code, but I can't test it locally, using 'mhipster' or calling 'jhipster --blueprints micronaut' or 'npx jhipster --blueprints micronaut' ends up with this error:
The developer setup is not documented at all, and I can't google it, how to solve. Any recommendation which works with the current JHipster generator? |
2946c89
to
ebde90f
Compare
@gzsombor I just merged the upgrade to JHipster 7.9.3, so you might try rebasing again. I created an app last night with the following command after running
|
ebde90f
to
4c812d2
Compare
Thanks, it turned out, if I don't want to use the development jhipster-generator, it works properly :) I've rebased, and fixed a couple of smaller issues around the DTO naming, I'm hopeful, that the tests will be green |
@gzsombor It looks like you need to run |
…y accessible user information from the private one. Porting jhipster/generator-jhipster#12374
3ae28ce
to
a56842f
Compare
thanks, I've rebased the change, and fixed the silly search&replace typo bug... This will work now :) |
And everything is green now, we can merge it :) |
To separate the publicly accessible user information from the private one.
Porting jhipster/generator-jhipster#12374