Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JHipster 7.9.3 version, and eliminate the unnecessary dropwizard … #286

Merged
merged 20 commits into from
Aug 21, 2023

Conversation

gzsombor
Copy link
Member

…dependency

@mraible
Copy link
Contributor

mraible commented Aug 18, 2023

Adding a bug bounty for this because I looked into it and couldn't figure it out.

@mraible mraible added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels Aug 18, 2023
@mraible
Copy link
Contributor

mraible commented Aug 19, 2023

Increasing bug bounty in hopes of a weekend fix! :)

@mraible mraible added $500 https://www.jhipster.tech/bug-bounties/ and removed $200 https://www.jhipster.tech/bug-bounties/ labels Aug 19, 2023
@gzsombor
Copy link
Member Author

That's definitely tricky :D I've just understood, that the templates under templates_back are not used, but this blueprint use the same templates as generator-jhipster.
So this is definitely strange, how that could cause problem with bytea/lob types on PostgreSQL, but not on the mainline...

@mraible
Copy link
Contributor

mraible commented Aug 19, 2023

Could it be related to Liquibase? I noticed that this blueprint has its own version specified.

@mraible
Copy link
Contributor

mraible commented Aug 19, 2023

@mshima Any idea why tests are failing?

@gzsombor
Copy link
Member Author

Probably, we still need FixedPostgreSQL10Dialect for blobs 😉

@mshima
Copy link
Member

mshima commented Aug 19, 2023

FixedPostgreSQL10Dialect is not required mshima@ae7db10.
Create a startWith at liquibase may fix the user constraint id error, but seems to trigger others errors: mshima@ab46a21

I've opened gzsombor#2 for reference, feel free to close or use.

@gzsombor
Copy link
Member Author

Thanks, I will have a look on it @mshima !
Is there any documentation about the fragments, how do they work?

@gzsombor
Copy link
Member Author

@mshima : that 'startsWith=1050' hack was not loved by the old h2database, which we still need to use on v7 maintenance, luckily, the userRepository.deleteAll() call was enough to fix the integration tests.
I'm still not 100% sure that the settings used in DomainUserDetailsServiceIT is the best way to configure the tests and the transactions, but it does it's job...
@mraible : I think, we can merge this 😄

@mshima
Copy link
Member

mshima commented Aug 20, 2023

Thanks, I will have a look on it @mshima !
Is there any documentation about the fragments, how do they work?

The initial commit has explanations jhipster/generator-jhipster#15494.

@mraible
Copy link
Contributor

mraible commented Aug 20, 2023

@gzsombor Please let me know if you'd still like me to merge this.

@gzsombor
Copy link
Member Author

I think this is fine,as of now

@mraible mraible merged commit 4e97373 into jhipster:main Aug 21, 2023
10 checks passed
@gzsombor gzsombor deleted the v7.9.3 branch August 21, 2023 15:28
@gzsombor
Copy link
Member Author

@DanielFran
Copy link
Member

@gzsombor approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $500 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants